Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

a typo in network #16514

Closed
wants to merge 3 commits into from
Closed

a typo in network #16514

wants to merge 3 commits into from

Conversation

janitha09
Copy link

netwok to network

Signed-off-by: janitha09 janitha_j@example.com

What this PR does / why we need it:

Which issue this PR fixes

(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

  • fixes #

Special notes for your reviewer:

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • [X ] DCO signed
  • Chart Version bumped
  • Variables are documented in the README.md
  • Title of the PR starts with chart name (e.g. [stable/chart])

@janitha09
a type in network
b094b34 
netwok to network
@helm-bot helm-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 21, 2019
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Aug 21, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @janitha09. Thanks for your PR.

I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: janitha09
To complete the pull request process, please assign kennethaasan
You can assign the PR to them by writing /assign @kennethaasan in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cpanato
Copy link
Member

cpanato commented Aug 21, 2019

@janitha09 can you please bump the chart version and sign the DCO ? thanks for this PR!

@pierluigilenoci
Copy link
Contributor

This change is also included in this PR: #16606

@pierluigilenoci
Copy link
Contributor

/assign @kennethaasan

@olemarkus
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 27, 2019
@k8s-ci-robot
Copy link
Contributor

@janitha09: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-charts-e2e f682063 link /test pull-charts-e2e

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@janitha09 janitha09 changed the title a type in network a typo in network Aug 28, 2019
@olemarkus olemarkus mentioned this pull request Aug 28, 2019
Closed
4 tasks
@pierluigilenoci
Copy link
Contributor

@janitha09 could you please close your PR? Now is outdated by this #16654

@olemarkus
Copy link
Contributor

/close

@janitha09 janitha09 closed this Sep 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kennethaasan kennethaasan Awaiting requested review from kennethaasan

@olemarkus olemarkus Awaiting requested review from olemarkus

Assignees

@kennethaasan kennethaasan

Labels
ok-to-test size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@janitha09 @k8s-ci-robot @cpanato @pierluigilenoci @olemarkus @kennethaasan @helm-bot